Marcus Meissner : advapi32: Close scm_handle on error exit (Coverity).

Alexandre Julliard julliard at winehq.org
Tue Jan 8 13:58:41 CST 2013


Module: wine
Branch: master
Commit: a422d6b382071f022596402fca33bc5c70e19da1
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=a422d6b382071f022596402fca33bc5c70e19da1

Author: Marcus Meissner <meissner at suse.de>
Date:   Mon Jan  7 22:17:33 2013 +0100

advapi32: Close scm_handle on error exit (Coverity).

---

 dlls/advapi32/tests/service.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/dlls/advapi32/tests/service.c b/dlls/advapi32/tests/service.c
index 2eeb40a..5248e82 100644
--- a/dlls/advapi32/tests/service.c
+++ b/dlls/advapi32/tests/service.c
@@ -1866,7 +1866,10 @@ static void test_sequence(void)
         }
     }
 
-    if (!svc_handle) return;
+    if (!svc_handle) {
+        CloseServiceHandle(scm_handle);
+        return;
+    }
 
     /* TODO:
      * Before we do a QueryServiceConfig we should check the registry. This will make sure




More information about the wine-cvs mailing list