Alexandre Julliard : winedbg: Use an if instead of a switch in case some float types have the same size.

Alexandre Julliard julliard at winehq.org
Tue Jan 8 13:58:43 CST 2013


Module: wine
Branch: master
Commit: e2761ab075da960c1b52f10e91f1e87b58d3c253
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=e2761ab075da960c1b52f10e91f1e87b58d3c253

Author: Alexandre Julliard <julliard at winehq.org>
Date:   Tue Jan  8 13:28:05 2013 +0100

winedbg: Use an if instead of a switch in case some float types have the same size.

---

 programs/winedbg/be_arm.c    |   11 +++++------
 programs/winedbg/be_i386.c   |   12 +++++-------
 programs/winedbg/be_x86_64.c |   12 +++++-------
 3 files changed, 15 insertions(+), 20 deletions(-)

diff --git a/programs/winedbg/be_arm.c b/programs/winedbg/be_arm.c
index 520cb06..00b6f5c 100644
--- a/programs/winedbg/be_arm.c
+++ b/programs/winedbg/be_arm.c
@@ -1875,12 +1875,11 @@ static int be_arm_fetch_float(const struct dbg_lvalue* lvalue, unsigned size,
      */
     if (!memory_read_value(lvalue, size, tmp)) return FALSE;
 
-    switch (size)
-    {
-    case sizeof(float):         *ret = *(float*)tmp;            break;
-    case sizeof(double):        *ret = *(double*)tmp;           break;
-    default:                    return FALSE;
-    }
+    if (size == sizeof(float)) *ret = *(float*)tmp;
+    else if (size == sizeof(double)) *ret = *(double*)tmp;
+    else if (size == sizeof(long double)) *ret = *(long double*)tmp;
+    else return FALSE;
+
     return TRUE;
 }
 
diff --git a/programs/winedbg/be_i386.c b/programs/winedbg/be_i386.c
index 5dc00ed..a20d732 100644
--- a/programs/winedbg/be_i386.c
+++ b/programs/winedbg/be_i386.c
@@ -767,13 +767,11 @@ static int be_i386_fetch_float(const struct dbg_lvalue* lvalue, unsigned size,
     if (!memory_read_value(lvalue, size, tmp)) return FALSE;
 
     /* float & double types have to be promoted to a long double */
-    switch (size)
-    {
-    case sizeof(float):         *ret = *(float*)tmp;            break;
-    case sizeof(double):        *ret = *(double*)tmp;           break;
-    case sizeof(long double):   *ret = *(long double*)tmp;      break;
-    default:                    return FALSE;
-    }
+    if (size == sizeof(float)) *ret = *(float*)tmp;
+    else if (size == sizeof(double)) *ret = *(double*)tmp;
+    else if (size == sizeof(long double)) *ret = *(long double*)tmp;
+    else return FALSE;
+
     return TRUE;
 }
 
diff --git a/programs/winedbg/be_x86_64.c b/programs/winedbg/be_x86_64.c
index 7fae50c..b97db3a 100644
--- a/programs/winedbg/be_x86_64.c
+++ b/programs/winedbg/be_x86_64.c
@@ -631,13 +631,11 @@ static int be_x86_64_fetch_float(const struct dbg_lvalue* lvalue, unsigned size,
     if (!memory_read_value(lvalue, size, tmp)) return FALSE;
 
     /* float & double types have to be promoted to a long double */
-    switch (size)
-    {
-    case sizeof(float):         *ret = *(float*)tmp;            break;
-    case sizeof(double):        *ret = *(double*)tmp;           break;
-    case sizeof(long double):   *ret = *(long double*)tmp;      break;
-    default:                    return FALSE;
-    }
+    if (size == sizeof(float)) *ret = *(float*)tmp;
+    else if (size == sizeof(double)) *ret = *(double*)tmp;
+    else if (size == sizeof(long double)) *ret = *(long double*)tmp;
+    else return FALSE;
+
     return TRUE;
 }
 




More information about the wine-cvs mailing list