Jacek Caban : mshtml: Don't use getElementsByTagNameNS in IHTMLDocument3:: getElementsByTagName implementation.

Alexandre Julliard julliard at winehq.org
Fri Mar 15 11:51:34 CDT 2013


Module: wine
Branch: master
Commit: 1d05cd515c168e45d38f344952b27b406ad07bc6
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=1d05cd515c168e45d38f344952b27b406ad07bc6

Author: Jacek Caban <jacek at codeweavers.com>
Date:   Fri Mar 15 15:01:23 2013 +0100

mshtml: Don't use getElementsByTagNameNS in IHTMLDocument3::getElementsByTagName implementation.

---

 dlls/mshtml/htmldoc3.c  |    7 ++-----
 dlls/mshtml/tests/dom.c |    2 +-
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/dlls/mshtml/htmldoc3.c b/dlls/mshtml/htmldoc3.c
index 4b9b12e..de5cdab 100644
--- a/dlls/mshtml/htmldoc3.c
+++ b/dlls/mshtml/htmldoc3.c
@@ -566,9 +566,8 @@ static HRESULT WINAPI HTMLDocument3_getElementsByTagName(IHTMLDocument3 *iface,
 {
     HTMLDocument *This = impl_from_IHTMLDocument3(iface);
     nsIDOMNodeList *nslist;
-    nsAString id_str, ns_str;
+    nsAString id_str;
     nsresult nsres;
-    static const WCHAR str[] = {'*',0};
 
     TRACE("(%p)->(%s %p)\n", This, debugstr_w(v), pelColl);
 
@@ -578,10 +577,8 @@ static HRESULT WINAPI HTMLDocument3_getElementsByTagName(IHTMLDocument3 *iface,
     }
 
     nsAString_InitDepend(&id_str, v);
-    nsAString_InitDepend(&ns_str, str);
-    nsres = nsIDOMHTMLDocument_GetElementsByTagNameNS(This->doc_node->nsdoc, &ns_str, &id_str, &nslist);
+    nsres = nsIDOMHTMLDocument_GetElementsByTagName(This->doc_node->nsdoc, &id_str, &nslist);
     nsAString_Finish(&id_str);
-    nsAString_Finish(&ns_str);
     if(FAILED(nsres)) {
         ERR("GetElementByName failed: %08x\n", nsres);
         return E_FAIL;
diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c
index d2be89f..2e4e3d8 100644
--- a/dlls/mshtml/tests/dom.c
+++ b/dlls/mshtml/tests/dom.c
@@ -6281,7 +6281,7 @@ static void test_elems(IHTMLDocument2 *doc)
     hres = IHTMLDocument2_QueryInterface(doc, &IID_IHTMLDocument3, (void**)&doc3);
     ok(hres == S_OK, "Could not get IHTMLDocument3 iface: %08x\n", hres);
 
-    str = a2bstr("img");
+    str = a2bstr("Img");
     hres = IHTMLDocument3_getElementsByTagName(doc3, str, &col);
     ok(hres == S_OK, "getElementsByTagName(%s) failed: %08x\n", wine_dbgstr_w(str), hres);
     SysFreeString(str);




More information about the wine-cvs mailing list