Francois Gouget : testbot/web: Simplify the jobs/steps/ tasks iteration code of the index page.

Alexandre Julliard julliard at winehq.org
Mon Mar 25 13:55:05 CDT 2013


Module: tools
Branch: master
Commit: a9936a0ad7970adc0cad00f3c4e0ccbe82c41790
URL:    http://source.winehq.org/git/tools.git/?a=commit;h=a9936a0ad7970adc0cad00f3c4e0ccbe82c41790

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Sun Mar 24 23:37:22 2013 +0100

testbot/web: Simplify the jobs/steps/tasks iteration code of the index page.

---

 testbot/web/index.pl |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/testbot/web/index.pl b/testbot/web/index.pl
index 6d88106..59bf16a 100644
--- a/testbot/web/index.pl
+++ b/testbot/web/index.pl
@@ -100,13 +100,11 @@ sub GenerateDataCell
     {
       my $Failures = 0;
       my $HasTestResult;
-      my $Steps = $Item->Steps;
-      foreach my $StepKey (@{$Steps->GetKeys()})
+      foreach my $Step (@{$Item->Steps->GetItems()})
       {
-        my $Tasks = $Steps->GetItem($StepKey)->Tasks;
-        foreach my $TaskKey (@{$Tasks->GetKeys()})
+        foreach my $Task (@{$Step->Tasks->GetItems()})
         {
-          my $TaskFailures = $Tasks->GetItem($TaskKey)->TestFailures;
+          my $TaskFailures = $Task->TestFailures;
           if ($TaskFailures ne "")
           {
             $HasTestResult = 1;




More information about the wine-cvs mailing list