Marcus Meissner : kernel32/tests: Avoid leaving com handle open (Coverity).
Alexandre Julliard
julliard at winehq.org
Mon Sep 2 14:34:28 CDT 2013
Module: wine
Branch: master
Commit: b084d7a4f8ff8b05b230271f76dd9c0c1f871b1b
URL: http://source.winehq.org/git/wine.git/?a=commit;h=b084d7a4f8ff8b05b230271f76dd9c0c1f871b1b
Author: Marcus Meissner <marcus at jet.franken.de>
Date: Sat Aug 31 10:16:48 2013 +0200
kernel32/tests: Avoid leaving com handle open (Coverity).
---
dlls/kernel32/tests/comm.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/dlls/kernel32/tests/comm.c b/dlls/kernel32/tests/comm.c
index e5264c8..6970cf9 100644
--- a/dlls/kernel32/tests/comm.c
+++ b/dlls/kernel32/tests/comm.c
@@ -1036,7 +1036,7 @@ static void test_LoopbackCtsRts(void)
if (dcb.fRtsControl == RTS_CONTROL_HANDSHAKE)
{
trace("RTS_CONTROL_HANDSHAKE is set, so don't manipulate RTS\n");
- CloseHandle(hcom);
+ CloseHandle(hcom);
return;
}
ok(GetCommModemStatus(hcom, &defaultStat), "GetCommModemStatus failed\n");
@@ -1180,6 +1180,7 @@ static void test_LoopbackDtrRing(void)
if (dcb.fDtrControl == DTR_CONTROL_HANDSHAKE)
{
trace("DTR_CONTROL_HANDSHAKE is set, so don't manipulate DTR\n");
+ CloseHandle(hcom);
return;
}
ok(GetCommModemStatus(hcom, &defaultStat), "GetCommModemStatus failed\n");
@@ -1592,6 +1593,7 @@ static void test_WaitRing(void)
ok((ret = GetCommModemStatus(hcom, &defaultStat)), "GetCommModemStatus failed\n");
if (!ret) {
skip("modem status failed -> skip.\n");
+ CloseHandle(hcom);
return;
}
if(defaultStat & MS_RING_ON)
@@ -1668,7 +1670,7 @@ static void test_WaitDcd(void)
if (dcb.fDtrControl == DTR_CONTROL_DISABLE)
{
trace("DTR_CONTROL_HANDSHAKE is set, so don't manipulate DTR\n");
- CloseHandle(hcom);
+ CloseHandle(hcom);
return;
}
args[0]= TIMEOUT >>1;
More information about the wine-cvs
mailing list