Zhenbo Li : mshtml: Don't free a string too early.

Alexandre Julliard julliard at winehq.org
Tue Apr 8 14:02:52 CDT 2014


Module: wine
Branch: master
Commit: c4a51b0b0afa2ad03bea76d540f6028532e7acd1
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=c4a51b0b0afa2ad03bea76d540f6028532e7acd1

Author: Zhenbo Li <litimetal at gmail.com>
Date:   Sun Apr  6 22:44:39 2014 +0800

mshtml: Don't free a string too early.

---

 dlls/mshtml/htmltablerow.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/mshtml/htmltablerow.c b/dlls/mshtml/htmltablerow.c
index f3a4970..74750bd 100644
--- a/dlls/mshtml/htmltablerow.c
+++ b/dlls/mshtml/htmltablerow.c
@@ -200,7 +200,6 @@ static HRESULT WINAPI HTMLTableRow_get_bgColor(IHTMLTableRow *iface, VARIANT *p)
 
     nsAString_Init(&strColor, NULL);
     nsres = nsIDOMHTMLTableRowElement_GetBgColor(This->nsrow, &strColor);
-    nsAString_Finish(&strColor);
 
     if(NS_SUCCEEDED(nsres)) {
        nsAString_GetData(&strColor, &color);
@@ -211,6 +210,7 @@ static HRESULT WINAPI HTMLTableRow_get_bgColor(IHTMLTableRow *iface, VARIANT *p)
        hres = E_FAIL;
     }
 
+    nsAString_Finish(&strColor);
     return hres;
 }
 




More information about the wine-cvs mailing list