Nikolay Sivov : msi: Fix a leak on error path (Coverity).

Alexandre Julliard julliard at winehq.org
Thu Apr 10 12:21:27 CDT 2014


Module: wine
Branch: master
Commit: 0bcf4a5bb6f164ed98e28cb57a07c7fbab7f99f8
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=0bcf4a5bb6f164ed98e28cb57a07c7fbab7f99f8

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Thu Apr 10 09:19:11 2014 +0400

msi: Fix a leak on error path (Coverity).

---

 dlls/msi/format.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/msi/format.c b/dlls/msi/format.c
index 3c815d9..581dd55 100644
--- a/dlls/msi/format.c
+++ b/dlls/msi/format.c
@@ -735,10 +735,10 @@ static UINT replace_stack(FORMAT *format, STACK *stack, STACK *values)
 
     format->n = n;
     beg = format_replace( format, propfound, nonprop, oldsize, type, replaced, len );
+    msi_free(replaced);
     if (!beg)
         return ERROR_SUCCESS;
 
-    msi_free(replaced);
     format->n = beg->n + beg->len;
 
     top = stack_peek(stack);




More information about the wine-cvs mailing list