Nikolay Sivov : odbccp32/tests: Remove test of always true conditions ( PVS-Studio).

Alexandre Julliard julliard at wine.codeweavers.com
Mon Aug 18 16:08:48 CDT 2014


Module: wine
Branch: master
Commit: 44677f2f7847d78dc20f4ce8cb29df1262c18a6d
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=44677f2f7847d78dc20f4ce8cb29df1262c18a6d

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Sat Aug 16 13:20:49 2014 +0400

odbccp32/tests: Remove test of always true conditions (PVS-Studio).

---

 dlls/odbccp32/tests/misc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/odbccp32/tests/misc.c b/dlls/odbccp32/tests/misc.c
index 40846e5..cfe9532 100644
--- a/dlls/odbccp32/tests/misc.c
+++ b/dlls/odbccp32/tests/misc.c
@@ -36,11 +36,11 @@ static void test_SQLConfigMode(void)
     bool_ret = SQLGetConfigMode(&config_mode);
     ok(bool_ret && config_mode == ODBC_BOTH_DSN, "Failed to get the initial SQLGetConfigMode or it was not both\n");
 
-    bool_ret = SQLSetConfigMode(3);
+    /* try to set invalid mode */
+    bool_ret = SQLSetConfigMode(ODBC_SYSTEM_DSN+1);
     sql_ret = SQLInstallerErrorW(1, &error_code, NULL, 0, NULL);
     ok(!bool_ret && sql_ret == SQL_SUCCESS_WITH_INFO && error_code == ODBC_ERROR_INVALID_PARAM_SEQUENCE, "SQLSetConfigMode with invalid argument did not fail correctly\n");
 
-    ok (ODBC_SYSTEM_DSN == 2 && ODBC_USER_DSN == 1 && ODBC_BOTH_DSN == 0, "SQLSetConfigMode modes not as expected\n");
     for (i = ODBC_SYSTEM_DSN; i >= ODBC_BOTH_DSN; --i)
     {
         ok(SQLSetConfigMode((UWORD)i), "SQLSetConfigMode Failed to set config mode\n");




More information about the wine-cvs mailing list