Nikolay Sivov : mshtml: Free buffer for empty strings too (PVS-Studio).

Alexandre Julliard julliard at wine.codeweavers.com
Mon Aug 18 16:08:48 CDT 2014


Module: wine
Branch: master
Commit: 2ee84d5ae21868fbc74efb6e6f99c2bbdf011dbb
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=2ee84d5ae21868fbc74efb6e6f99c2bbdf011dbb

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Sat Aug 16 13:53:13 2014 +0400

mshtml: Free buffer for empty strings too (PVS-Studio).

---

 dlls/mshtml/oleobj.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/mshtml/oleobj.c b/dlls/mshtml/oleobj.c
index ea8cea6..ca01288 100644
--- a/dlls/mshtml/oleobj.c
+++ b/dlls/mshtml/oleobj.c
@@ -375,7 +375,7 @@ static HRESULT WINAPI OleObject_SetClientSite(IOleObject *iface, IOleClientSite
                     (void**)&uihandler2);
             if(SUCCEEDED(hres)) {
                 hres = IDocHostUIHandler2_GetOverrideKeyPath(uihandler2, &override_key_path, 0);
-                if(hres == S_OK && override_key_path && override_key_path[0]) {
+                if(hres == S_OK && override_key_path) {
                     if(override_key_path[0]) {
                         /*FIXME: use override_key_path */
                         FIXME("override_key_path = %s\n", debugstr_w(override_key_path));




More information about the wine-cvs mailing list