=?UTF-8?Q?Stefan=20D=C3=B6singer=20?=: wined3d: Add a comment about reset during focus change.

Alexandre Julliard julliard at wine.codeweavers.com
Tue Dec 2 13:40:21 CST 2014


Module: wine
Branch: master
Commit: f103247ddf2debba343cce4594fcaaad58917eac
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=f103247ddf2debba343cce4594fcaaad58917eac

Author: Stefan Dösinger <stefan at codeweavers.com>
Date:   Mon Dec  1 22:46:48 2014 +0100

wined3d: Add a comment about reset during focus change.

---

 dlls/wined3d/swapchain.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/dlls/wined3d/swapchain.c b/dlls/wined3d/swapchain.c
index 362f0ae..89f83ea 100644
--- a/dlls/wined3d/swapchain.c
+++ b/dlls/wined3d/swapchain.c
@@ -1176,6 +1176,11 @@ void swapchain_update_draw_bindings(struct wined3d_swapchain *swapchain)
 
 void wined3d_swapchain_activate(struct wined3d_swapchain *swapchain, BOOL activate)
 {
+    /* This code is not protected by the wined3d mutex, so it may run while
+     * wined3d_device_reset is active. Testing on Windows shows that changing
+     * focus during resets and resetting during focus change events causes
+     * the application to crash with an invalid memory access. */
+
     if (activate)
     {
         if (!(swapchain->device->create_parms.flags & WINED3DCREATE_NOWINDOWCHANGES))




More information about the wine-cvs mailing list