Gerald Pfeifer : wordpad: Avoid an out-of-bounds array access in registry_set_filelist.

Alexandre Julliard julliard at wine.codeweavers.com
Wed Dec 31 15:59:34 CST 2014


Module: wine
Branch: master
Commit: c7482ad1c1baa8c7cf9d1a4a3034e76592386d1e
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=c7482ad1c1baa8c7cf9d1a4a3034e76592386d1e

Author: Gerald Pfeifer <gerald at pfeifer.com>
Date:   Sat Dec 27 09:57:41 2014 +0100

wordpad: Avoid an out-of-bounds array access in registry_set_filelist.

---

 programs/wordpad/registry.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/programs/wordpad/registry.c b/programs/wordpad/registry.c
index 5b570e7..22b5c06 100644
--- a/programs/wordpad/registry.c
+++ b/programs/wordpad/registry.c
@@ -318,7 +318,7 @@ void registry_set_filelist(LPCWSTR newFile, HWND hMainWnd)
                 pFiles[0] = newFile;
             }
 
-            for(i = 0; pFiles[i] && i < FILELIST_ENTRIES; i++)
+            for(i = 0; i < FILELIST_ENTRIES && pFiles[i]; i++)
             {
                 wsprintfW(buffer, var_file, i+1);
                 RegSetValueExW(hKey, (LPWSTR)&buffer, 0, REG_SZ, (const BYTE*)pFiles[i],




More information about the wine-cvs mailing list