Nikolay Sivov : oleaut32: No need to VariantClear() before VariantCopy().

Alexandre Julliard julliard at winehq.org
Wed Feb 19 14:48:17 CST 2014


Module: wine
Branch: master
Commit: 6f30f699cc7da0f9e1227bc316711f3d3fa2d6a8
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=6f30f699cc7da0f9e1227bc316711f3d3fa2d6a8

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Wed Feb 19 18:51:34 2014 +0400

oleaut32: No need to VariantClear() before VariantCopy().

---

 dlls/oleaut32/safearray.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/dlls/oleaut32/safearray.c b/dlls/oleaut32/safearray.c
index 436a2ca..b7d8b37 100644
--- a/dlls/oleaut32/safearray.c
+++ b/dlls/oleaut32/safearray.c
@@ -884,8 +884,6 @@ HRESULT WINAPI SafeArrayPutElement(SAFEARRAY *psa, LONG *rgIndices, void *pvData
         VARIANT* lpVariant = pvData;
         VARIANT* lpDest = lpvDest;
 
-        hRet = VariantClear(lpDest);
-        if (FAILED(hRet)) FIXME("VariantClear failed with 0x%x\n", hRet);
         hRet = VariantCopy(lpDest, lpVariant);
         if (FAILED(hRet)) FIXME("VariantCopy failed with 0x%x\n", hRet);
       }




More information about the wine-cvs mailing list