Dmitry Timoshkov : shlwapi: Avoid a not necessary intermediate variable.
Alexandre Julliard
julliard at winehq.org
Wed Feb 19 14:48:17 CST 2014
Module: wine
Branch: master
Commit: 99eab9d3c78d2c59ebfc0fd046414b5f7c717298
URL: http://source.winehq.org/git/wine.git/?a=commit;h=99eab9d3c78d2c59ebfc0fd046414b5f7c717298
Author: Dmitry Timoshkov <dmitry at baikal.ru>
Date: Mon Feb 17 14:48:39 2014 +0900
shlwapi: Avoid a not necessary intermediate variable.
---
dlls/shlwapi/istream.c | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/dlls/shlwapi/istream.c b/dlls/shlwapi/istream.c
index 2e365d6..bbd331a 100644
--- a/dlls/shlwapi/istream.c
+++ b/dlls/shlwapi/istream.c
@@ -294,16 +294,14 @@ static HRESULT WINAPI IStream_fnLockUnlockRegion(IStream *iface, ULARGE_INTEGER
static HRESULT WINAPI IStream_fnStat(IStream *iface, STATSTG* lpStat,
DWORD grfStatFlag)
{
- ISHFileStream *This = impl_from_IStream(iface);
- BY_HANDLE_FILE_INFORMATION fi;
- HRESULT hRet = S_OK;
+ ISHFileStream *This = impl_from_IStream(iface);
+ BY_HANDLE_FILE_INFORMATION fi;
- TRACE("(%p,%p,%d)\n", This, lpStat, grfStatFlag);
+ TRACE("(%p,%p,%d)\n", This, lpStat, grfStatFlag);
+
+ if (!grfStatFlag)
+ return STG_E_INVALIDPOINTER;
- if (!grfStatFlag)
- hRet = STG_E_INVALIDPOINTER;
- else
- {
memset(&fi, 0, sizeof(fi));
GetFileInformationByHandle(This->hFile, &fi);
@@ -322,8 +320,8 @@ static HRESULT WINAPI IStream_fnStat(IStream *iface, STATSTG* lpStat,
memcpy(&lpStat->clsid, &IID_IStream, sizeof(CLSID));
lpStat->grfStateBits = This->grfStateBits;
lpStat->reserved = 0;
- }
- return hRet;
+
+ return S_OK;
}
/*************************************************************************
More information about the wine-cvs
mailing list