Alexander Nicolaysen =?UTF-8?Q?S=C3=B8rnes=20?=: screenshot: Mark some functions as static

Alexander Nicolaysen Sørnes asornes at winehq.org
Sun Jan 12 08:57:18 CST 2014


Module: appdb
Branch: master
Commit: 36fb1d97de5cdd02dcdfda5708f2f949373e03e6
URL:    http://source.winehq.org/git/appdb.git/?a=commit;h=36fb1d97de5cdd02dcdfda5708f2f949373e03e6

Author: Alexander Nicolaysen Sørnes <alexsornes at gmail.com>
Date:   Sun Jan 12 15:28:31 2014 +0100

screenshot: Mark some functions as static

---

 include/screenshot.php |   17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/include/screenshot.php b/include/screenshot.php
index dc49935..adb0658 100644
--- a/include/screenshot.php
+++ b/include/screenshot.php
@@ -464,7 +464,7 @@ class screenshot
             mail_appdb($sEmail, $sSubject ,$sMsg);
     } 
 
-    function get_zoomicon_overlay()
+    public static function get_zoomicon_overlay()
     {
         /* if the user is using mozilla or firefox show the zoom icon over images */
         /* otherwise because IE doesn't support transparent PNGs or proper css we have to */
@@ -485,7 +485,7 @@ class screenshot
      *
      * $bFormatting == false turns off all extranious formatting applied to the returned image html
      */
-    function get_random_screenshot_img($iAppId = null, $iVersionId = null,
+    public static function get_random_screenshot_img($iAppId = null, $iVersionId = null,
                                        $bFormatting = true) 
     {
         // initialize variables to avoid notices when appending to them
@@ -554,7 +554,14 @@ class screenshot
         return $sImg;
     }
 
-    function get_screenshots($iAppId = null, $iVersionId = null, $bQueued = "false")
+    /**
+     * Get all screenshots for an application or a specific version
+     * @param type $iAppId
+     * @param type $iVersionId
+     * @param type $bQueued
+     * @return boolean
+     */
+    public static function get_screenshots($iAppId = null, $iVersionId = null, $bQueued = "false")
     {
         /*
          * We want all screenshots for this app.
@@ -703,13 +710,13 @@ class screenshot
         return $oFilter;
     }
 
-    function objectGetEntries($sState, $iRows = 0, $iStart = 0, $sOrderBy = '', $bAscending = true, $oFilters = null)
+    public static function objectGetEntries($sState, $iRows = 0, $iStart = 0, $sOrderBy = '', $bAscending = true, $oFilters = null)
     {
         return appData::objectGetEntries($sState, $iRows, $iStart, $sOrderBy, $bAscending,
                                          'screenshot', $oFilters);
     }
 
-    function objectGetEntriesCount($sState, $oFilters = null)
+    public static function objectGetEntriesCount($sState, $oFilters = null)
     {
         return appData::objectGetEntriesCount($sState, 'screenshot', $oFilters);
     }




More information about the wine-cvs mailing list