Francois Gouget : testbot/web: Improve argument handling in the web methods.

Thu Jun 12 11:29:30 CDT 2014

Module: tools
Branch: master
Commit: 95b5ea0176af8ef17e4e262ce7e6cd31b7c80e6e
URL:    http://source.winehq.org/git/tools.git/?a=commit;h=95b5ea0176af8ef17e4e262ce7e6cd31b7c80e6e

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Mon Jun  9 12:29:32 2014 +0200

testbot/web: Improve argument handling in the web methods.

This standardizes the way we handle arguments.  Make it so one can
readily see the list of arguments the method takes without having to
hunt down the implementation of all its ancestors.  Because these are
methods the added prototypes have no effect whatsoever as far as Perl
is concerned. However they do document which arguments are optional.

---

 testbot/web/Feedback.pl            |   44 +++++++--------
 testbot/web/ForgotPassword.pl      |   29 +++++-----
 testbot/web/GetFile.pl             |    2 +-
 testbot/web/JobDetails.pl          |   76 ++++++++++++--------------
 testbot/web/Login.pl               |   36 ++++++------
 testbot/web/Logout.pl              |   12 ++--
 testbot/web/PatchesList.pl         |   41 ++++++--------
 testbot/web/Register.pl            |   48 ++++++++--------
 testbot/web/ResetPassword.pl       |   40 +++++++-------
 testbot/web/Screenshot.pl          |    8 +--
 testbot/web/Submit.pl              |  106 +++++++++++++++++-------------------
 testbot/web/admin/BranchDetails.pl |    6 +-
 testbot/web/admin/BranchesList.pl  |   11 ++--
 testbot/web/admin/UserDetails.pl   |   30 +++++-----
 testbot/web/admin/UsersList.pl     |   30 +++++-----
 testbot/web/admin/VMDetails.pl     |   13 ++---
 testbot/web/admin/VMsList.pl       |   24 ++++----
 testbot/web/index.pl               |   68 +++++++++++------------
 18 files changed, 299 insertions(+), 325 deletions(-)

Diff:   http://source.winehq.org/git/tools.git/?a=commitdiff;h=95b5ea0176af8ef17e4e262ce7e6cd31b7c80e6e