Francois Gouget : testbot/web: Use the default Domain and Path of our cookies.

Alexandre Julliard julliard at winehq.org
Thu Jun 12 11:29:30 CDT 2014


Module: tools
Branch: master
Commit: 70ebd159c77017701d59d92f391a502e80bea2d3
URL:    http://source.winehq.org/git/tools.git/?a=commit;h=70ebd159c77017701d59d92f391a502e80bea2d3

Author: Francois Gouget <fgouget at codeweavers.com>
Date:   Mon Jun  9 12:43:28 2014 +0200

testbot/web: Use the default Domain and Path of our cookies.

The Path defaults to '/' which is what we want.  The Domain is set to
the most restrictive value which is good.  This also means we're no
longer putting the port number in the Domain value which fixes our
cookies when the web server is running on a non-standard port or the
connection is going through port forwarding.

---

 testbot/lib/WineTestBot/CGI/PageBase.pm |    4 ----
 1 file changed, 4 deletions(-)

diff --git a/testbot/lib/WineTestBot/CGI/PageBase.pm b/testbot/lib/WineTestBot/CGI/PageBase.pm
index bfa44c4..a724507 100644
--- a/testbot/lib/WineTestBot/CGI/PageBase.pm
+++ b/testbot/lib/WineTestBot/CGI/PageBase.pm
@@ -162,8 +162,6 @@ sub SetCookies($)
       $Cookie = CGI::Cookie->new(-Name    => "SessionId",
                                  -Value   => $Session->Id,
                                  -Expires => $Expire,
-                                 -Domain  => $ENV{"HTTP_HOST"},
-                                 -Path    => "/",
                                  -Secure  => $UseSSL);
       $Request->err_headers_out->add("Set-Cookie", $Cookie);
     }
@@ -184,8 +182,6 @@ sub SetCookies($)
     $Cookie = CGI::Cookie->new(-Name    => "SessionActive",
                                -Value   => $SessionPermanent,
                                -Expires => $Expire,
-                               -Domain  => $ENV{"HTTP_HOST"},
-                               -Path    => "/",
                                -Secure  => !1);
     $Request->err_headers_out->add("Set-Cookie", $Cookie);
   }




More information about the wine-cvs mailing list