Nikolay Sivov : explorerframe/tests: Mark some results as broken.

Alexandre Julliard julliard at winehq.org
Thu Jun 12 15:51:42 CDT 2014


Module: wine
Branch: master
Commit: 3d691afd9732269e8d9e4cd5e59c59a679092c57
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=3d691afd9732269e8d9e4cd5e59c59a679092c57

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Wed Jun 11 08:28:17 2014 +0400

explorerframe/tests: Mark some results as broken.

---

 dlls/explorerframe/tests/nstc.c |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/dlls/explorerframe/tests/nstc.c b/dlls/explorerframe/tests/nstc.c
index 6eefa93..1d0c14c 100644
--- a/dlls/explorerframe/tests/nstc.c
+++ b/dlls/explorerframe/tests/nstc.c
@@ -690,14 +690,16 @@ static BOOL test_initialization(void)
     }
 
     /* Some "random" interfaces */
+
+    /* Next three are supported on Vista/2k8, but not on newer versions */
     hr = INameSpaceTreeControl_QueryInterface(pnstc, &IID_IOleInPlaceObject, (void**)&punk);
-    ok(hr == E_NOINTERFACE || hr == S_OK /* vista, w2k8 */, "Got (0x%08x)\n", hr);
+    ok(hr == E_NOINTERFACE || broken(hr == S_OK) /* vista, w2k8 */, "Got (0x%08x)\n", hr);
     if(SUCCEEDED(hr)) IUnknown_Release(punk);
     hr = INameSpaceTreeControl_QueryInterface(pnstc, &IID_IOleInPlaceActiveObject, (void**)&punk);
-    ok(hr == E_NOINTERFACE || hr == S_OK /* vista, w2k8 */, "Got (0x%08x)\n", hr);
+    ok(hr == E_NOINTERFACE || broken(hr == S_OK) /* vista, w2k8 */, "Got (0x%08x)\n", hr);
     if(SUCCEEDED(hr)) IUnknown_Release(punk);
     hr = INameSpaceTreeControl_QueryInterface(pnstc, &IID_IOleInPlaceObjectWindowless, (void**)&punk);
-    ok(hr == E_NOINTERFACE || hr == S_OK /* vista, w2k8 */, "Got (0x%08x)\n", hr);
+    ok(hr == E_NOINTERFACE || broken(hr == S_OK) /* vista, w2k8 */, "Got (0x%08x)\n", hr);
     if(SUCCEEDED(hr)) IUnknown_Release(punk);
 
     hr = INameSpaceTreeControl_QueryInterface(pnstc, &IID_IOleInPlaceUIWindow, (void**)&punk);
@@ -2223,7 +2225,7 @@ static void test_events(void)
     itemstate = 0xDEADBEEF;
     hr = INameSpaceTreeControl_GetItemState(pnstc, psidesktop, 0xffff, &itemstate);
     ok(hr == S_OK, "Got (0x%08x)\n", hr);
-    ok(itemstate == (NSTCIS_BOLD), "itemstate is 0x%08x\n", itemstate);
+    ok(itemstate == NSTCIS_BOLD, "itemstate is 0x%08x\n", itemstate);
     ok_no_events(pnstceimpl);
 
     hr = INameSpaceTreeControl_RemoveAllRoots(pnstc);
@@ -2406,9 +2408,7 @@ START_TEST(nstc)
         test_events();
     }
     else
-    {
         win_skip("No NamespaceTreeControl (or instantiation failed).\n");
-    }
 
     destroy_window();
     OleUninitialize();




More information about the wine-cvs mailing list