Nikolay Sivov : windowscodecs/tests: Fixed some leaks on error path ( Valgrind).

Alexandre Julliard julliard at winehq.org
Mon Jun 16 12:37:49 CDT 2014


Module: wine
Branch: master
Commit: 7e3ab90187a0e7ccf1bfb0604695a91fb781cb96
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=7e3ab90187a0e7ccf1bfb0604695a91fb781cb96

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Sun Jun 15 00:21:53 2014 +0400

windowscodecs/tests: Fixed some leaks on error path (Valgrind).

---

 dlls/windowscodecs/tests/metadata.c |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/dlls/windowscodecs/tests/metadata.c b/dlls/windowscodecs/tests/metadata.c
index 7f35c42..e42b474 100644
--- a/dlls/windowscodecs/tests/metadata.c
+++ b/dlls/windowscodecs/tests/metadata.c
@@ -845,7 +845,13 @@ static void test_create_reader(void)
         stream, &reader);
 todo_wine
     ok(hr == S_OK, "CreateMetadataReaderFromContainer failed, hr=%x\n", hr);
-    if (FAILED(hr)) return;
+    /* NOTE: removed once Wine is fixed */
+    if (FAILED(hr))
+    {
+        IStream_Release(stream);
+        IWICComponentFactory_Release(factory);
+        return;
+    }
 
     if (SUCCEEDED(hr))
     {




More information about the wine-cvs mailing list