Vincent Povirk : windowscodecs: Fix leak in DGifGetImageDesc.

Alexandre Julliard julliard at winehq.org
Wed Jun 18 14:31:41 CDT 2014


Module: wine
Branch: master
Commit: bb8fdb734ed1552f0d9bf9b2bcec614d29d72bc2
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=bb8fdb734ed1552f0d9bf9b2bcec614d29d72bc2

Author: Vincent Povirk <vincent at codeweavers.com>
Date:   Thu Jun 12 14:15:21 2014 -0500

windowscodecs: Fix leak in DGifGetImageDesc.

---

 dlls/windowscodecs/ungif.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/dlls/windowscodecs/ungif.c b/dlls/windowscodecs/ungif.c
index c2887ed..427b32f 100644
--- a/dlls/windowscodecs/ungif.c
+++ b/dlls/windowscodecs/ungif.c
@@ -405,10 +405,7 @@ DGifGetImageDesc(GifFileType * GifFile) {
     GifFile->Image.Interlace = (Buf[0] & 0x40);
     if (Buf[0] & 0x80) {    /* Does this image have local color map? */
 
-        /*** FIXME: Why do we check both of these in order to do this?
-         * Why do we have both Image and SavedImages? */
-        if (GifFile->Image.ColorMap && GifFile->SavedImages == NULL)
-            FreeMapObject(GifFile->Image.ColorMap);
+        FreeMapObject(GifFile->Image.ColorMap);
 
         GifFile->Image.ColorMap = MakeMapObject(1 << BitsPerPixel, NULL);
         if (GifFile->Image.ColorMap == NULL) {




More information about the wine-cvs mailing list