Marcus Meissner : msi: Fixed missing free in an error path (Coverity).

Alexandre Julliard julliard at winehq.org
Mon Mar 10 14:38:28 CDT 2014


Module: wine
Branch: master
Commit: 3fa41c9e701a2bc4a9173738dfcf233ff565fe4f
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=3fa41c9e701a2bc4a9173738dfcf233ff565fe4f

Author: Marcus Meissner <marcus at jet.franken.de>
Date:   Sat Mar  8 09:48:58 2014 +0100

msi: Fixed missing free in an error path (Coverity).

---

 dlls/msi/action.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/dlls/msi/action.c b/dlls/msi/action.c
index 0d9fb69..4c6d6af 100644
--- a/dlls/msi/action.c
+++ b/dlls/msi/action.c
@@ -5813,7 +5813,11 @@ static UINT ITERATE_InstallService(MSIRECORD *rec, LPVOID param)
         ERR("Query failed\n");
         goto done;
     }
-    if (!(key = MSI_RecordGetString(row, 6))) goto done;
+    if (!(key = MSI_RecordGetString(row, 6)))
+    {
+        msiobj_release(&row->hdr);
+        goto done;
+    }
     file = msi_get_loaded_file(package, key);
     msiobj_release(&row->hdr);
     if (!file)




More information about the wine-cvs mailing list