Nikolay Sivov : comctl32: Fix a leak on error path (Coverity).

Alexandre Julliard julliard at winehq.org
Tue Mar 25 14:27:43 CDT 2014


Module: wine
Branch: master
Commit: d60910fc149d49639b4e8d077f0bb1099cf8016f
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=d60910fc149d49639b4e8d077f0bb1099cf8016f

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Mon Mar 24 21:35:02 2014 +0400

comctl32: Fix a leak on error path (Coverity).

---

 dlls/comctl32/dpa.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/dlls/comctl32/dpa.c b/dlls/comctl32/dpa.c
index 41fb799..148d3f1 100644
--- a/dlls/comctl32/dpa.c
+++ b/dlls/comctl32/dpa.c
@@ -129,8 +129,10 @@ HRESULT WINAPI DPA_LoadStream (HDPA *phDpa, PFNDPASTREAM loadProc,
     if (!hDpa)
         return E_OUTOFMEMORY;
 
-    if (!DPA_Grow (hDpa, streamData.dwItems))
+    if (!DPA_Grow (hDpa, streamData.dwItems)) {
+        DPA_Destroy (hDpa);
         return E_OUTOFMEMORY;
+    }
 
     /* load data from the stream into the dpa */
     ptr = hDpa->ptrs;




More information about the wine-cvs mailing list