Nikolay Sivov : msxml3/tests: Fix a BSTR leak (Valgrind).

Alexandre Julliard julliard at winehq.org
Mon May 5 15:03:26 CDT 2014


Module: wine
Branch: master
Commit: 30410d48fd46e9e58f35e96df9aa323520444bbf
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=30410d48fd46e9e58f35e96df9aa323520444bbf

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Sun May  4 20:33:03 2014 +0400

msxml3/tests: Fix a BSTR leak (Valgrind).

---

 dlls/msxml3/tests/domdoc.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c
index 7a2f984..8d8c7c0 100644
--- a/dlls/msxml3/tests/domdoc.c
+++ b/dlls/msxml3/tests/domdoc.c
@@ -11045,7 +11045,6 @@ static void test_xmlns_attribute(void)
     hr = IXMLDOMDocument_appendChild(doc, (IXMLDOMNode*)root, NULL);
     EXPECT_HR(hr, S_OK);
 
-    str = SysAllocString(szAttribute);
     hr = IXMLDOMDocument_createAttribute(doc, _bstr_("xmlns:dt"), &pAttribute);
     ok( hr == S_OK, "returns %08x\n", hr );
 
@@ -11062,16 +11061,16 @@ static void test_xmlns_attribute(void)
     hr = IXMLDOMDocument_get_documentElement(doc, &elem);
     EXPECT_HR(hr, S_OK);
 
+    str = NULL;
     hr = IXMLDOMElement_get_xml(elem, &str);
     ok( hr == S_OK, "got 0x%08x\n", hr);
     todo_wine ok( lstrcmpW(str, _bstr_("<Testing xmlns:dt=\"urn:schemas-microsoft-com:datatypes\" dt:dt=\"bin.base64\"/>")) == 0,
     "got %s\n", wine_dbgstr_w(str));
+    SysFreeString(str);
 
     IXMLDOMElement_Release(elem);
     IXMLDOMAttribute_Release( pAttribute);
 
-    SysFreeString(str);
-
     IXMLDOMDocument_Release(doc);
 
     free_bstrs();




More information about the wine-cvs mailing list