Marcus Meissner : jsproxy: Avoid potential NULL dereference (Coverity).

Alexandre Julliard julliard at winehq.org
Tue May 20 14:36:24 CDT 2014


Module: wine
Branch: master
Commit: 0dda8a14db8d83505670f1375966d35ed3c05ecd
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=0dda8a14db8d83505670f1375966d35ed3c05ecd

Author: Marcus Meissner <marcus at jet.franken.de>
Date:   Tue May 20 08:47:38 2014 +0200

jsproxy: Avoid potential NULL dereference (Coverity).

---

 dlls/jsproxy/main.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/dlls/jsproxy/main.c b/dlls/jsproxy/main.c
index 4d02b07..0399173 100644
--- a/dlls/jsproxy/main.c
+++ b/dlls/jsproxy/main.c
@@ -103,8 +103,11 @@ static inline WCHAR *strdupAW( const char *src, DWORD len )
     if (src)
     {
         int dst_len = MultiByteToWideChar( CP_ACP, 0, src, len, NULL, 0 );
-        if ((dst = heap_alloc( (dst_len + 1) * sizeof(WCHAR) ))) len = MultiByteToWideChar( CP_ACP, 0, src, len, dst, dst_len );
-        dst[dst_len] = 0;
+        if ((dst = heap_alloc( (dst_len + 1) * sizeof(WCHAR) )))
+        {
+            len = MultiByteToWideChar( CP_ACP, 0, src, len, dst, dst_len );
+            dst[dst_len] = 0;
+        }
     }
     return dst;
 }




More information about the wine-cvs mailing list