Jacek Caban : mshtml: Properly handle errors in IHTMLStyleSheet:: get_rules now that Gecko part is fixed.

Alexandre Julliard julliard at wine.codeweavers.com
Thu Nov 13 07:40:25 CST 2014


Module: wine
Branch: master
Commit: 6fc5977241bd8e86ba71e1c5b0b07cd9d9c43b2e
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=6fc5977241bd8e86ba71e1c5b0b07cd9d9c43b2e

Author: Jacek Caban <jacek at codeweavers.com>
Date:   Thu Nov 13 11:22:35 2014 +0100

mshtml: Properly handle errors in IHTMLStyleSheet::get_rules now that Gecko part is fixed.

---

 dlls/mshtml/htmlstylesheet.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/dlls/mshtml/htmlstylesheet.c b/dlls/mshtml/htmlstylesheet.c
index 8f48a07..6480975 100644
--- a/dlls/mshtml/htmlstylesheet.c
+++ b/dlls/mshtml/htmlstylesheet.c
@@ -649,11 +649,11 @@ static HRESULT WINAPI HTMLStyleSheet_get_rules(IHTMLStyleSheet *iface,
 
     TRACE("(%p)->(%p)\n", This, p);
 
-    /* Gecko has buggy security checks and GetCssRules will fail. We have a correct
-     * implementation and it will work when the bug will be fixed in Gecko. */
     nsres = nsIDOMCSSStyleSheet_GetCssRules(This->nsstylesheet, &nslist);
-    if(NS_FAILED(nsres))
-        WARN("GetCssRules failed: %08x\n", nsres);
+    if(NS_FAILED(nsres)) {
+        ERR("GetCssRules failed: %08x\n", nsres);
+        return E_FAIL;
+    }
 
     *p = HTMLStyleSheetRulesCollection_Create(nslist);
     return S_OK;




More information about the wine-cvs mailing list