Michael Stefaniuc : crypt32/tests: Don't compare the result to itself ( PVS-Studio).

Alexandre Julliard julliard at wine.codeweavers.com
Wed Oct 29 07:36:58 CDT 2014


Module: wine
Branch: master
Commit: d3c565f44b55cd66fb57227e3a74d3d4ff52acb4
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=d3c565f44b55cd66fb57227e3a74d3d4ff52acb4

Author: Michael Stefaniuc <mstefani at redhat.de>
Date:   Wed Oct 29 09:21:50 2014 +0100

crypt32/tests: Don't compare the result to itself (PVS-Studio).

---

 dlls/crypt32/tests/encode.c | 2 +-
 dlls/crypt32/tests/msg.c    | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/crypt32/tests/encode.c b/dlls/crypt32/tests/encode.c
index 16b3532..9e1853f 100644
--- a/dlls/crypt32/tests/encode.c
+++ b/dlls/crypt32/tests/encode.c
@@ -3732,7 +3732,7 @@ static void compareAltNameEntry(const CERT_ALT_NAME_ENTRY *expected,
         case CERT_ALT_NAME_IP_ADDRESS:
             ok(U(*got).IPAddress.cbData == U(*expected).IPAddress.cbData,
                "Unexpected IP address length %d\n", U(*got).IPAddress.cbData);
-            ok(!memcmp(U(*got).IPAddress.pbData, U(*got).IPAddress.pbData,
+            ok(!memcmp(U(*got).IPAddress.pbData, U(*expected).IPAddress.pbData,
                        U(*got).IPAddress.cbData), "Unexpected value\n");
             break;
         }
diff --git a/dlls/crypt32/tests/msg.c b/dlls/crypt32/tests/msg.c
index b40302a..e9887b0 100644
--- a/dlls/crypt32/tests/msg.c
+++ b/dlls/crypt32/tests/msg.c
@@ -2666,12 +2666,12 @@ static void compare_signer_info(const CMSG_SIGNER_INFO *got,
     ok(got->Issuer.cbData == expected->Issuer.cbData,
      "Expected issuer size %d, got %d\n", expected->Issuer.cbData,
      got->Issuer.cbData);
-    ok(!memcmp(got->Issuer.pbData, got->Issuer.pbData, got->Issuer.cbData),
+    ok(!memcmp(got->Issuer.pbData, expected->Issuer.pbData, got->Issuer.cbData),
      "Unexpected issuer\n");
     ok(got->SerialNumber.cbData == expected->SerialNumber.cbData,
      "Expected serial number size %d, got %d\n", expected->SerialNumber.cbData,
      got->SerialNumber.cbData);
-    ok(!memcmp(got->SerialNumber.pbData, got->SerialNumber.pbData,
+    ok(!memcmp(got->SerialNumber.pbData, expected->SerialNumber.pbData,
      got->SerialNumber.cbData), "Unexpected serial number\n");
     /* FIXME: check more things */
 }




More information about the wine-cvs mailing list