Nikolay Sivov : msxml3: Return S_FALSE in getNamedItem() of PI node.
Alexandre Julliard
julliard at wine.codeweavers.com
Thu Oct 30 09:23:15 CDT 2014
Module: wine
Branch: master
Commit: 04305134486cadfb78643a8796ab6a13fec6c202
URL: http://source.winehq.org/git/wine.git/?a=commit;h=04305134486cadfb78643a8796ab6a13fec6c202
Author: Nikolay Sivov <nsivov at codeweavers.com>
Date: Thu Oct 30 11:06:27 2014 +0300
msxml3: Return S_FALSE in getNamedItem() of PI node.
---
dlls/msxml3/pi.c | 4 +++-
dlls/msxml3/tests/domdoc.c | 5 +++++
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/dlls/msxml3/pi.c b/dlls/msxml3/pi.c
index 6b8fc12..96fb118 100644
--- a/dlls/msxml3/pi.c
+++ b/dlls/msxml3/pi.c
@@ -685,7 +685,9 @@ static HRESULT dom_pi_get_qualified_item(const xmlNodePtr node, BSTR name, BSTR
static HRESULT dom_pi_get_named_item(const xmlNodePtr node, BSTR name, IXMLDOMNode **item)
{
FIXME("(%p)->(%s %p): stub\n", node, debugstr_w(name), item );
- return E_NOTIMPL;
+ if (item)
+ *item = NULL;
+ return S_FALSE;
}
static HRESULT dom_pi_set_named_item(xmlNodePtr node, IXMLDOMNode *newItem, IXMLDOMNode **namedItem)
diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c
index 038df04..b768260 100644
--- a/dlls/msxml3/tests/domdoc.c
+++ b/dlls/msxml3/tests/domdoc.c
@@ -9152,6 +9152,11 @@ static void test_get_attributes(void)
hr = IXMLDOMNode_get_attributes(node, &map);
ok(hr == S_OK, "got %08x\n", hr);
+ node2 = (void*)0xdeadbeef;
+ hr = IXMLDOMNamedNodeMap_getNamedItem(map, _bstr_("attr"), &node2);
+ ok(hr == S_FALSE, "got %08x\n", hr);
+ ok(node2 == NULL, "got %p\n", node2);
+
length = -1;
hr = IXMLDOMNamedNodeMap_get_length(map, &length);
EXPECT_HR(hr, S_OK);
More information about the wine-cvs
mailing list