Marcus Meissner : dwrite: Fixed NULL ptr deref before check (Coverity).

Alexandre Julliard julliard at wine.codeweavers.com
Mon Sep 22 15:01:13 CDT 2014


Module: wine
Branch: master
Commit: 90774871c844e2bb39b8d6350f48b4a12ede1ccd
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=90774871c844e2bb39b8d6350f48b4a12ede1ccd

Author: Marcus Meissner <marcus at jet.franken.de>
Date:   Sun Sep 21 14:44:43 2014 +0200

dwrite: Fixed NULL ptr deref before check (Coverity).

---

 dlls/dwrite/font.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/dwrite/font.c b/dlls/dwrite/font.c
index efa305e..6e7de46 100644
--- a/dlls/dwrite/font.c
+++ b/dlls/dwrite/font.c
@@ -390,9 +390,9 @@ static HRESULT WINAPI dwritefontface_TryGetFontTable(IDWriteFontFace *iface, UIN
         TRACE("(%p)->(%u %p %p %p %p)\n", This, table_tag, table_data, table_size, context, exists);
 
         table = heap_alloc(sizeof(struct dwrite_fonttable));
-        table->magic = DWRITE_FONTTABLE_MAGIC;
         if (!table)
             return E_OUTOFMEMORY;
+        table->magic = DWRITE_FONTTABLE_MAGIC;
 
         *exists = FALSE;
         for (i = 0; i < This->data->file_count && !(*exists); i++)




More information about the wine-cvs mailing list