Thomas Faber : setupapi/tests: Avoid side-effect in an assert.

Alexandre Julliard julliard at wine.codeweavers.com
Fri Apr 3 07:14:59 CDT 2015


Module: wine
Branch: master
Commit: 655e7f98dba96bef8db711c5859e271a0c26122c
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=655e7f98dba96bef8db711c5859e271a0c26122c

Author: Thomas Faber <thomas.faber at reactos.org>
Date:   Fri Apr  3 07:55:50 2015 +0200

setupapi/tests: Avoid side-effect in an assert.

---

 dlls/setupapi/tests/install.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/dlls/setupapi/tests/install.c b/dlls/setupapi/tests/install.c
index fdee524..a98cbec 100644
--- a/dlls/setupapi/tests/install.c
+++ b/dlls/setupapi/tests/install.c
@@ -63,10 +63,12 @@ static BOOL (WINAPI *pSetupGetInfFileListW)(PCWSTR, DWORD, PWSTR, DWORD, PDWORD)
 static void create_inf_file(LPCSTR filename, const char *data)
 {
     DWORD res;
+    BOOL ret;
     HANDLE handle = CreateFileA(filename, GENERIC_WRITE, 0, NULL,
                            CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL);
     assert(handle != INVALID_HANDLE_VALUE);
-    assert(WriteFile(handle, data, strlen(data), &res, NULL));
+    ret = WriteFile(handle, data, strlen(data), &res, NULL);
+    assert(ret != 0);
     CloseHandle(handle);
 }
 




More information about the wine-cvs mailing list