Jacek Caban : msxml3: Create unknode object only for node types supported by msxml.

Alexandre Julliard julliard at wine.codeweavers.com
Thu Apr 16 07:56:28 CDT 2015


Module: wine
Branch: master
Commit: 20b2e1bdb58b2b0d88b94fb9af7c3254cdd9ba2c
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=20b2e1bdb58b2b0d88b94fb9af7c3254cdd9ba2c

Author: Jacek Caban <jacek at codeweavers.com>
Date:   Thu Apr 16 12:32:17 2015 +0200

msxml3: Create unknode object only for node types supported by msxml.

---

 dlls/msxml3/node.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/dlls/msxml3/node.c b/dlls/msxml3/node.c
index 0f591b4..7119a43 100644
--- a/dlls/msxml3/node.c
+++ b/dlls/msxml3/node.c
@@ -2038,9 +2038,11 @@ IXMLDOMNode *create_node( xmlNodePtr node )
         pUnk = create_doc_fragment( node );
         break;
     case XML_DTD_NODE:
+    case XML_DOCUMENT_TYPE_NODE:
         pUnk = create_doc_type( node );
         break;
-    default: {
+    case XML_ENTITY_NODE:
+    case XML_NOTATION_NODE: {
         unknode *new_node;
 
         FIXME("only creating basic node for type %d\n", node->type);
@@ -2054,6 +2056,9 @@ IXMLDOMNode *create_node( xmlNodePtr node )
         init_xmlnode(&new_node->node, node, &new_node->IXMLDOMNode_iface, NULL);
         pUnk = (IUnknown*)&new_node->IXMLDOMNode_iface;
     }
+    default:
+        ERR("Called for unsupported node type %d\n", node->type);
+        return NULL;
     }
 
     hr = IUnknown_QueryInterface(pUnk, &IID_IXMLDOMNode, (LPVOID*)&ret);




More information about the wine-cvs mailing list