=?UTF-8?Q?Andr=C3=A9=20Hentschel=20?=: mmdevapi: Skip device if GetId fails (Coverity).

Alexandre Julliard julliard at wine.codeweavers.com
Wed Dec 23 18:22:07 CST 2015


Module: wine
Branch: master
Commit: bbc42a2341c9eb3181d3b9e845bb3c551667a95c
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=bbc42a2341c9eb3181d3b9e845bb3c551667a95c

Author: André Hentschel <nerv at dawncrow.de>
Date:   Tue Dec 22 23:18:46 2015 +0100

mmdevapi: Skip device if GetId fails (Coverity).

Signed-off-by: André Hentschel <nerv at dawncrow.de>
Signed-off-by: Andrew Eikum <aeikum at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/mmdevapi/devenum.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/dlls/mmdevapi/devenum.c b/dlls/mmdevapi/devenum.c
index d50d206..e63a199 100644
--- a/dlls/mmdevapi/devenum.c
+++ b/dlls/mmdevapi/devenum.c
@@ -1065,9 +1065,15 @@ static HRESULT WINAPI MMDevEnum_GetDevice(IMMDeviceEnumerator *iface, const WCHA
 
     for (i = 0; i < MMDevice_count; ++i)
     {
+        HRESULT hr;
         WCHAR *str;
         dev = &MMDevice_head[i]->IMMDevice_iface;
-        IMMDevice_GetId(dev, &str);
+        hr = IMMDevice_GetId(dev, &str);
+        if (FAILED(hr))
+        {
+            WARN("GetId failed: %08x\n", hr);
+            continue;
+        }
 
         if (str && !lstrcmpW(str, name))
         {




More information about the wine-cvs mailing list