=?UTF-8?Q?Andr=C3=A9=20Hentschel=20?=: services: Fix access adjustment by reordering code (Clang).

Alexandre Julliard julliard at wine.codeweavers.com
Thu Dec 24 14:40:05 CST 2015


Module: wine
Branch: master
Commit: 67e5e8edf6aee9599cde3d037f443257fd07f5a3
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=67e5e8edf6aee9599cde3d037f443257fd07f5a3

Author: André Hentschel <nerv at dawncrow.de>
Date:   Tue Dec 22 19:29:16 2015 +0100

services: Fix access adjustment by reordering code (Clang).

Signed-off-by: André Hentschel <nerv at dawncrow.de>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 programs/services/rpc.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/programs/services/rpc.c b/programs/services/rpc.c
index 89a8c91..dd44965 100644
--- a/programs/services/rpc.c
+++ b/programs/services/rpc.c
@@ -352,12 +352,13 @@ static DWORD create_handle_for_service(struct service_entry *entry, DWORD dwDesi
         return ERROR_NOT_ENOUGH_SERVER_MEMORY;
     }
 
+    if (dwDesiredAccess & MAXIMUM_ALLOWED)
+        dwDesiredAccess |= SERVICE_ALL_ACCESS;
+
     service->hdr.type = SC_HTYPE_SERVICE;
     service->hdr.access = dwDesiredAccess;
     RtlMapGenericMask(&service->hdr.access, &g_svc_generic);
     service->service_entry = entry;
-    if (dwDesiredAccess & MAXIMUM_ALLOWED)
-        dwDesiredAccess |= SERVICE_ALL_ACCESS;
 
     *phService = &service->hdr;
     return ERROR_SUCCESS;




More information about the wine-cvs mailing list