Nikolay Sivov : vbscript: Fix potential crash if script site creation failed.

Alexandre Julliard julliard at wine.codeweavers.com
Mon Feb 16 10:01:20 CST 2015


Module: wine
Branch: master
Commit: dba0fe3614b2bf8002551a7636cc90c7315e2c8d
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=dba0fe3614b2bf8002551a7636cc90c7315e2c8d

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Mon Feb 16 11:30:11 2015 +0300

vbscript: Fix potential crash if script site creation failed.

---

 dlls/vbscript/global.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/dlls/vbscript/global.c b/dlls/vbscript/global.c
index 77fc1d6..448b886 100644
--- a/dlls/vbscript/global.c
+++ b/dlls/vbscript/global.c
@@ -209,11 +209,12 @@ static HRESULT set_object_site(script_ctx_t *ctx, IUnknown *obj)
         return S_OK;
 
     ax_site = create_ax_site(ctx);
-    if(ax_site)
+    if(ax_site) {
         hres = IObjectWithSite_SetSite(obj_site, ax_site);
+        IUnknown_Release(ax_site);
+    }
     else
         hres = E_OUTOFMEMORY;
-    IUnknown_Release(ax_site);
     IObjectWithSite_Release(obj_site);
     return hres;
 }




More information about the wine-cvs mailing list