Michael Stefaniuc : oleaut32/tests: Remove an always true conditional subexpression (PVS-Studio).

Alexandre Julliard julliard at wine.codeweavers.com
Mon Feb 23 09:04:43 CST 2015


Module: wine
Branch: master
Commit: 724ee1d4fcf5807c490e60c2a99926de6a2ce34c
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=724ee1d4fcf5807c490e60c2a99926de6a2ce34c

Author: Michael Stefaniuc <mstefani at redhat.de>
Date:   Sat Feb 21 18:06:16 2015 +0100

oleaut32/tests: Remove an always true conditional subexpression (PVS-Studio).

---

 dlls/oleaut32/tests/vartest.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/oleaut32/tests/vartest.c b/dlls/oleaut32/tests/vartest.c
index 7ed4fd4..cf9e101 100644
--- a/dlls/oleaut32/tests/vartest.c
+++ b/dlls/oleaut32/tests/vartest.c
@@ -7548,7 +7548,7 @@ static void test_VarDiv(void)
                 }
 
                 /* Determine return type */
-                if (!(rightvt == VT_EMPTY))
+                if (rightvt != VT_EMPTY)
                 {
                     if (leftvt == VT_NULL || rightvt == VT_NULL)
                         resvt = VT_NULL;
@@ -7577,7 +7577,7 @@ static void test_VarDiv(void)
                     else if (leftvt == VT_R4 || rightvt == VT_R4)
                         resvt = VT_R4;
                 }
-                else if (leftvt == VT_NULL && rightvt == VT_EMPTY)
+                else if (leftvt == VT_NULL)
                     resvt = VT_NULL;
                 else
                     bFail = TRUE;




More information about the wine-cvs mailing list