Michael Stefaniuc : rsaenh: Remove an always false conditional subexpression (PVS-Studio).

Alexandre Julliard julliard at wine.codeweavers.com
Mon Feb 23 09:04:43 CST 2015


Module: wine
Branch: master
Commit: 17e565dbf91c3de8570d1581790aeb85aec5a971
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=17e565dbf91c3de8570d1581790aeb85aec5a971

Author: Michael Stefaniuc <mstefani at redhat.de>
Date:   Sat Feb 21 18:22:26 2015 +0100

rsaenh: Remove an always false conditional subexpression (PVS-Studio).

---

 dlls/rsaenh/mpi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/rsaenh/mpi.c b/dlls/rsaenh/mpi.c
index e964676..f75d89f 100644
--- a/dlls/rsaenh/mpi.c
+++ b/dlls/rsaenh/mpi.c
@@ -1955,8 +1955,8 @@ int mp_exptmod (const mp_int * G, const mp_int * X, mp_int * P, mp_int * Y)
 
   dr = 0;
 
-  /* if the modulus is odd or dr != 0 use the fast method */
-  if (mp_isodd (P) == 1 || dr !=  0) {
+  /* if the modulus is odd use the fast method */
+  if (mp_isodd (P) == 1) {
     return mp_exptmod_fast (G, X, P, Y, dr);
   } else {
     /* otherwise use the generic Barrett reduction technique */




More information about the wine-cvs mailing list