Huw Davies : comctl32: The number of buttons is set by the first TBN_RESTORE notification.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 77ed3733af8b8c45c2a8a89db4a9f31733eec397
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=77ed3733af8b8c45c2a8a89db4a9f31733eec397

Author: Huw Davies <huw at codeweavers.com>
Date:   Wed Jul  1 09:14:55 2015 +0100

comctl32: The number of buttons is set by the first TBN_RESTORE notification.

---

 dlls/comctl32/tests/toolbar.c | 49 +++++++++++++++++++++++++++++++++++++++++++
 dlls/comctl32/toolbar.c       |  4 ++--
 2 files changed, 51 insertions(+), 2 deletions(-)

diff --git a/dlls/comctl32/tests/toolbar.c b/dlls/comctl32/tests/toolbar.c
index 18dc534..9535947 100644
--- a/dlls/comctl32/tests/toolbar.c
+++ b/dlls/comctl32/tests/toolbar.c
@@ -163,7 +163,45 @@ static LRESULT parent_wnd_notify(LPARAM lParam)
             /* Return value is ignored */
             return 1;
         }
+        case TBN_RESTORE:
+        {
+            NMTBRESTORE *restore = (NMTBRESTORE *)lParam;
+
+            if (restore->iItem == -1)
+            {
+                ok( restore->cButtons == 15, "got %d\n", restore->cButtons );
+                ok( *restore->pCurrent == 0xcafe, "got %08x\n", *restore->pCurrent );
+                /* Skip the last one */
+                restore->cButtons = 6;
+                restore->pCurrent++;
+                /* BytesPerRecord is ignored */
+                restore->cbBytesPerRecord = 10;
+            }
+            else
+            {
+                ok( *restore->pCurrent == 0xcafe0000 + restore->iItem, "got %08x\n", *restore->pCurrent );
+                ok( restore->tbButton.iBitmap == -1, "got %08x\n", restore->tbButton.iBitmap );
+                ok( restore->tbButton.idCommand == restore->iItem * 2 + 1, "got %08x\n", restore->tbButton.idCommand );
+                ok( restore->tbButton.fsState == 0, "got %02x\n", restore->tbButton.fsState );
+                ok( restore->tbButton.fsStyle == 0, "got %02x\n", restore->tbButton.fsStyle );
+                ok( restore->tbButton.dwData == 0, "got %08lx\n", restore->tbButton.dwData );
+                ok( restore->tbButton.iString == 0, "got %08lx\n", restore->tbButton.iString );
+
+                restore->tbButton.iBitmap = 0;
+                restore->tbButton.fsState = TBSTATE_ENABLED;
+                restore->tbButton.fsStyle = 0;
+                restore->tbButton.iString = -1;
+
+                restore->pCurrent++;
+                /* Altering cButtons after the 1st call makes no difference. */
+                restore->cButtons--;
+            }
 
+            /* Returning non-zero from the 1st call aborts the restore,
+               otherwise the return value is ignored. */
+            if (restore->iItem == -1) return 0;
+            return 1;
+        }
     }
     return 0;
 }
@@ -2161,6 +2199,17 @@ static void test_save(void)
     ok( size == sizeof(expect), "got %08x\n", size );
     ok( !memcmp( data, expect, size ), "mismatch\n" );
 
+    RegCloseKey( key );
+
+    wnd = NULL;
+    rebuild_toolbar( &wnd );
+    res = SendMessageW( wnd, TB_SAVERESTOREW, FALSE, (LPARAM)&params );
+    ok( res, "restoring failed\n" );
+    res = SendMessageW( wnd, TB_BUTTONCOUNT, 0, 0 );
+    ok( res == 6, "got %d\n", res );
+
+    DestroyWindow( wnd );
+    RegOpenKeyW( HKEY_CURRENT_USER, subkey, &key );
     RegDeleteValueW( key, value );
     RegCloseKey( key );
 }
diff --git a/dlls/comctl32/toolbar.c b/dlls/comctl32/toolbar.c
index e230d885..9c3707b 100644
--- a/dlls/comctl32/toolbar.c
+++ b/dlls/comctl32/toolbar.c
@@ -4183,13 +4183,13 @@ TOOLBAR_Restore(TOOLBAR_INFO *infoPtr, const TBSAVEPARAMSW *lpSave)
 
         if (!TOOLBAR_SendNotify(&nmtbr.hdr, infoPtr, TBN_RESTORE))
         {
-            INT i;
+            INT i, count = nmtbr.cButtons;
 
             /* remove all existing buttons as this function is designed to
              * restore the toolbar to a previously saved state */
             TOOLBAR_DeleteAllButtons(infoPtr);
 
-            for (i = 0; i < nmtbr.cButtons; i++)
+            for (i = 0; i < count; i++)
             {
                 nmtbr.iItem = i;
                 nmtbr.tbButton.iBitmap = -1;