Nikolay Sivov : shell32: Handle string-to-guid conversion errors (Coverity ).
Alexandre Julliard
julliard at wine.codeweavers.com
Mon Jul 6 06:37:36 CDT 2015
Module: wine
Branch: master
Commit: 69733d65e82035a4375042e283bf9720f833ca69
URL: http://source.winehq.org/git/wine.git/?a=commit;h=69733d65e82035a4375042e283bf9720f833ca69
Author: Nikolay Sivov <nsivov at codeweavers.com>
Date: Mon Jul 6 09:09:06 2015 +0300
shell32: Handle string-to-guid conversion errors (Coverity).
---
dlls/shell32/shellpath.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/dlls/shell32/shellpath.c b/dlls/shell32/shellpath.c
index 42f34a2..1a4528f 100644
--- a/dlls/shell32/shellpath.c
+++ b/dlls/shell32/shellpath.c
@@ -5334,7 +5334,11 @@ static HRESULT WINAPI knownfolder_GetFolderDefinition(
hr = HRESULT_FROM_WIN32(RegGetValueW(HKEY_LOCAL_MACHINE, knownfolder->registryPath, szParentFolder,
RRF_RT_REG_SZ, NULL, parentGuid, &dwSize));
if(SUCCEEDED(hr))
- IIDFromString(parentGuid, &pKFD->fidParent);
+ {
+ hr = IIDFromString(parentGuid, &pKFD->fidParent);
+ if(FAILED(hr))
+ return hr;
+ }
get_known_folder_dword(knownfolder->registryPath, szAttributes, &pKFD->dwAttributes);
More information about the wine-cvs
mailing list