Hans Leidekker : msi: Check the return value of MSI_QueryGetRecord ( Coverity).
Alexandre Julliard
julliard at wine.codeweavers.com
Wed Jul 15 09:51:24 CDT 2015
Module: wine
Branch: master
Commit: 17405f6b91d310ec2dbb53f23eb6acc861817003
URL: http://source.winehq.org/git/wine.git/?a=commit;h=17405f6b91d310ec2dbb53f23eb6acc861817003
Author: Hans Leidekker <hans at codeweavers.com>
Date: Wed Jul 15 15:13:11 2015 +0200
msi: Check the return value of MSI_QueryGetRecord (Coverity).
---
dlls/msi/action.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/dlls/msi/action.c b/dlls/msi/action.c
index 3ad387a..c90114c 100644
--- a/dlls/msi/action.c
+++ b/dlls/msi/action.c
@@ -3554,7 +3554,9 @@ static UINT ACTION_ProcessComponents(MSIPACKAGE *package)
if (!comp->KeyPath || !(file = msi_get_loaded_file(package, comp->KeyPath)))
continue;
- row = MSI_QueryGetRecord(package->db, query, file->Sequence);
+ if (!(row = MSI_QueryGetRecord(package->db, query, file->Sequence)))
+ return ERROR_FUNCTION_FAILED;
+
sprintfW(source, fmt, MSI_RecordGetInteger(row, 1));
ptr2 = strrchrW(source, '\\') + 1;
msiobj_release(&row->hdr);
More information about the wine-cvs
mailing list