Huw Davies : net: Don't call CloseServiceHandle() with an invalid handle.

Alexandre Julliard julliard at wine.codeweavers.com
Thu Jul 16 08:37:19 CDT 2015


Module: wine
Branch: master
Commit: 3e7f0e685b79ad507dbd821f84c1ce392c32095c
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=3e7f0e685b79ad507dbd821f84c1ce392c32095c

Author: Huw Davies <huw at codeweavers.com>
Date:   Thu Jul 16 11:56:07 2015 +0100

net: Don't call CloseServiceHandle() with an invalid handle.

---

 programs/net/net.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/programs/net/net.c b/programs/net/net.c
index 7149ea8..2e540ea 100644
--- a/programs/net/net.c
+++ b/programs/net/net.c
@@ -220,8 +220,11 @@ static BOOL StopService(SC_HANDLE SCManager, SC_HANDLE serviceHandle)
             {
                 output_string(STRING_STOP_DEP, dependencies[counter].lpDisplayName);
                 dependent_serviceHandle = OpenServiceW(SCManager, dependencies[counter].lpServiceName, SC_MANAGER_ALL_ACCESS);
-                if(dependent_serviceHandle) result = StopService(SCManager, dependent_serviceHandle);
-                CloseServiceHandle(dependent_serviceHandle);
+                if(dependent_serviceHandle)
+                {
+                    result = StopService(SCManager, dependent_serviceHandle);
+                    CloseServiceHandle(dependent_serviceHandle);
+                }
                 if(!result) output_string(STRING_CANT_STOP, dependencies[counter].lpDisplayName);
            }
         }




More information about the wine-cvs mailing list