Nikolay Sivov : mshtml/tests: Fix use-after-free in events tests.

Alexandre Julliard julliard at wine.codeweavers.com
Mon Jun 1 07:36:59 CDT 2015


Module: wine
Branch: master
Commit: a3916f636d9bebf18dcb0bdd3411fc047a60f3fe
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=a3916f636d9bebf18dcb0bdd3411fc047a60f3fe

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Fri May 29 19:12:12 2015 +0300

mshtml/tests: Fix use-after-free in events tests.

---

 dlls/mshtml/tests/events.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/mshtml/tests/events.c b/dlls/mshtml/tests/events.c
index 11a91da..07549e3 100644
--- a/dlls/mshtml/tests/events.c
+++ b/dlls/mshtml/tests/events.c
@@ -1076,13 +1076,13 @@ static HRESULT WINAPI submit_onclick_setret(IDispatchEx *iface, DISPID id, LCID
 
     hres = IHTMLEventObj_put_returnValue(event, onclick_event_retval);
     ok(hres == S_OK, "put_returnValue failed: %08x\n", hres);
-    IHTMLEventObj_Release(event);
 
     V_VT(&v) = VT_ERROR;
     hres = IHTMLEventObj_get_returnValue(event, &v);
     ok(hres == S_OK, "get_returnValue failed: %08x\n", hres);
     ok(VarCmp(&v, &onclick_event_retval, 0, 0) == VARCMP_EQ, "unexpected returnValue\n");
 
+    IHTMLEventObj_Release(event);
     *pvarRes = onclick_retval;
     return S_OK;
 }
@@ -1108,9 +1108,9 @@ static HRESULT WINAPI submit_onclick_cancel(IDispatchEx *iface, DISPID id, LCID
 
     hres = IHTMLEventObj_put_cancelBubble(event, VARIANT_TRUE);
     ok(hres == S_OK, "put_returnValue failed: %08x\n", hres);
-    IHTMLEventObj_Release(event);
 
     test_event_cancelbubble(event, VARIANT_TRUE);
+    IHTMLEventObj_Release(event);
     return S_OK;
 }
 




More information about the wine-cvs mailing list