Nikolay Sivov : ole32: Avoid potential null pointer access (Coverity).

Alexandre Julliard julliard at wine.codeweavers.com
Mon Jun 1 07:36:59 CDT 2015


Module: wine
Branch: master
Commit: 5c0e48e8ca523dece3d2556a223c1d675abbedbd
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=5c0e48e8ca523dece3d2556a223c1d675abbedbd

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Sun May 31 15:03:50 2015 +0300

ole32: Avoid potential null pointer access (Coverity).

---

 dlls/ole32/moniker.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/ole32/moniker.c b/dlls/ole32/moniker.c
index 6f7afa0..fee205c 100644
--- a/dlls/ole32/moniker.c
+++ b/dlls/ole32/moniker.c
@@ -1211,10 +1211,10 @@ HRESULT WINAPI GetClassFile(LPCOLESTR filePathName,CLSID *pclsid)
 
         res=StgOpenStorage(filePathName,NULL,STGM_READ | STGM_SHARE_DENY_WRITE,NULL,0,&pstg);
 
-        if (SUCCEEDED(res))
+        if (SUCCEEDED(res)) {
             res=ReadClassStg(pstg,pclsid);
-
-        IStorage_Release(pstg);
+            IStorage_Release(pstg);
+        }
 
         return res;
     }




More information about the wine-cvs mailing list