Nikolay Sivov : comctl32/toolbar: Remove always true condition (Coverity).

Alexandre Julliard julliard at wine.codeweavers.com
Wed Jun 3 09:43:08 CDT 2015


Module: wine
Branch: master
Commit: b7969dfd9413ab21ccf0a36d085f78077cb351e2
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=b7969dfd9413ab21ccf0a36d085f78077cb351e2

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Wed Jun  3 11:10:24 2015 +0300

comctl32/toolbar: Remove always true condition (Coverity).

---

 dlls/comctl32/toolbar.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/dlls/comctl32/toolbar.c b/dlls/comctl32/toolbar.c
index ecf0604..2c7ed63 100644
--- a/dlls/comctl32/toolbar.c
+++ b/dlls/comctl32/toolbar.c
@@ -3347,8 +3347,7 @@ TOOLBAR_GetButtonInfoT(const TOOLBAR_INFO *infoPtr, INT Id, LPTBBUTTONINFOW lpTb
     if (nIndex == -1)
 	return -1;
 
-    if (!(btnPtr = &infoPtr->buttons[nIndex])) return -1;
-
+    btnPtr = &infoPtr->buttons[nIndex];
     if (lpTbInfo->dwMask & TBIF_COMMAND)
 	lpTbInfo->idCommand = btnPtr->idCommand;
     if (lpTbInfo->dwMask & TBIF_IMAGE)




More information about the wine-cvs mailing list