Nikolay Sivov : winex11: Remove unreachable XFreePixmap(), mask_pixmap is always NULL on failure (Coverity).

Alexandre Julliard julliard at wine.codeweavers.com
Wed Jun 3 09:43:08 CDT 2015


Module: wine
Branch: master
Commit: c0af3fad4ef02ac82e472f05048e866506aae589
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=c0af3fad4ef02ac82e472f05048e866506aae589

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Wed Jun  3 13:52:11 2015 +0300

winex11: Remove unreachable XFreePixmap(), mask_pixmap is always NULL on failure (Coverity).

---

 dlls/winex11.drv/window.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/dlls/winex11.drv/window.c b/dlls/winex11.drv/window.c
index ea37dd7..14dc44c 100644
--- a/dlls/winex11.drv/window.c
+++ b/dlls/winex11.drv/window.c
@@ -573,7 +573,6 @@ static BOOL create_icon_pixmaps( HDC hdc, const ICONINFO *icon, Pixmap *icon_ret
 
 failed:
     if (color_pixmap) XFreePixmap( gdi_display, color_pixmap );
-    if (mask_pixmap) XFreePixmap( gdi_display, mask_pixmap );
     HeapFree( GetProcessHeap(), 0, bits.ptr );
     return FALSE;
 }




More information about the wine-cvs mailing list