Nikolay Sivov : oleaut32: Improve error handling in GetRecordInfoFromTypeInfo() (Coverity).

Alexandre Julliard julliard at wine.codeweavers.com
Wed Jun 3 09:43:09 CDT 2015


Module: wine
Branch: master
Commit: 8d4f56810775757edc87f6f01754df7f9e98d7e3
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=8d4f56810775757edc87f6f01754df7f9e98d7e3

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Wed Jun  3 16:04:16 2015 +0300

oleaut32: Improve error handling in GetRecordInfoFromTypeInfo() (Coverity).

---

 dlls/oleaut32/recinfo.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/dlls/oleaut32/recinfo.c b/dlls/oleaut32/recinfo.c
index f60fb8a..ec65a52 100644
--- a/dlls/oleaut32/recinfo.c
+++ b/dlls/oleaut32/recinfo.c
@@ -650,7 +650,12 @@ HRESULT WINAPI GetRecordInfoFromTypeInfo(ITypeInfo* pTI, IRecordInfo** ppRecInfo
             WARN("GetRefTypeInfo failed: %08x\n", hres);
             return hres;
         }
-        ITypeInfo_GetTypeAttr(pTypeInfo, &typeattr);
+        hres = ITypeInfo_GetTypeAttr(pTypeInfo, &typeattr);
+        if(FAILED(hres)) {
+            ITypeInfo_Release(pTypeInfo);
+            WARN("GetTypeAttr failed for referenced type: %08x\n", hres);
+            return hres;
+        }
     }else  {
         pTypeInfo = pTI;
         ITypeInfo_AddRef(pTypeInfo);




More information about the wine-cvs mailing list