Nikolay Sivov : ieframe/tests: Fix some leaks (Valgrind).

Alexandre Julliard julliard at wine.codeweavers.com
Mon Jun 22 07:44:58 CDT 2015


Module: wine
Branch: master
Commit: 71cf22e5b0714eb9c854bbcb776d44845f28ef2c
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=71cf22e5b0714eb9c854bbcb776d44845f28ef2c

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Sun Jun 21 09:36:39 2015 +0300

ieframe/tests: Fix some leaks (Valgrind).

---

 dlls/ieframe/tests/intshcut.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/dlls/ieframe/tests/intshcut.c b/dlls/ieframe/tests/intshcut.c
index ef99d42..75c6cfb 100644
--- a/dlls/ieframe/tests/intshcut.c
+++ b/dlls/ieframe/tests/intshcut.c
@@ -156,13 +156,14 @@ static void _check_string_transform(unsigned line, IUniformResourceLocatorA *url
         todo_wine
         ok_(__FILE__,line)(!lstrcmpA(output, expectedOutput), "unexpected URL change %s -> %s (expected %s)\n",
             input, output, expectedOutput);
-        CoTaskMemFree(output);
     }else {
         todo_wine
         ok_(__FILE__,line)(hr == S_FALSE, "GetUrl failed, hr=0x%x\n", hr);
         todo_wine
         ok_(__FILE__,line)(!output, "GetUrl returned %s\n", output);
     }
+    if (hr == S_OK)
+        CoTaskMemFree(output);
 }
 
 static void test_ReadAndWriteProperties(void)
@@ -252,7 +253,7 @@ static void test_ReadAndWriteProperties(void)
         hr = urlAFromFile->lpVtbl->GetURL(urlAFromFile, &url);
         ok(hr == S_OK, "Unable to get url from file, hr=0x%x\n", hr);
         ok(lstrcmpA(url, testurl) == 0, "Wrong url read from file: %s\n",url);
-
+        CoTaskMemFree(url);
 
         hr = urlAFromFile->lpVtbl->QueryInterface(urlAFromFile, &IID_IPropertySetStorage, (void **) &pPropSetStg);
         ok(hr == S_OK, "Unable to get an IPropertySetStorage, hr=0x%x\n", hr);
@@ -381,6 +382,7 @@ static void test_InternetShortcut(void)
     ok(hres == S_OK, "Could not create CLSID_InternetShortcut instance: %08x\n", hres);
     if(FAILED(hres))
         return;
+    url->lpVtbl->Release(url);
 
     test_Aggregability();
     test_QueryInterface();




More information about the wine-cvs mailing list