Nikolay Sivov : gdiplus: Check GetMetadataFormat() return value (Coverity) .

Alexandre Julliard julliard at wine.codeweavers.com
Mon Jun 29 08:12:09 CDT 2015


Module: wine
Branch: master
Commit: c2ae34c54d5e385c8f85a2b28a0328bf57e1fd0d
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=c2ae34c54d5e385c8f85a2b28a0328bf57e1fd0d

Author: Nikolay Sivov <nsivov at codeweavers.com>
Date:   Sat Jun 27 14:29:37 2015 +0300

gdiplus: Check GetMetadataFormat() return value (Coverity).

---

 dlls/gdiplus/image.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/dlls/gdiplus/image.c b/dlls/gdiplus/image.c
index 351c5b3..73f2f74 100644
--- a/dlls/gdiplus/image.c
+++ b/dlls/gdiplus/image.c
@@ -3058,8 +3058,8 @@ static BOOL get_bool_property(IWICMetadataReader *reader, const GUID *guid, cons
     PROPVARIANT id, value;
     BOOL ret = FALSE;
 
-    IWICMetadataReader_GetMetadataFormat(reader, &format);
-    if (!IsEqualGUID(&format, guid)) return FALSE;
+    hr = IWICMetadataReader_GetMetadataFormat(reader, &format);
+    if (FAILED(hr) || !IsEqualGUID(&format, guid)) return FALSE;
 
     PropVariantInit(&id);
     PropVariantInit(&value);
@@ -3085,8 +3085,8 @@ static PropertyItem *get_property(IWICMetadataReader *reader, const GUID *guid,
     PROPVARIANT id, value;
     PropertyItem *item = NULL;
 
-    IWICMetadataReader_GetMetadataFormat(reader, &format);
-    if (!IsEqualGUID(&format, guid)) return NULL;
+    hr = IWICMetadataReader_GetMetadataFormat(reader, &format);
+    if (FAILED(hr) || !IsEqualGUID(&format, guid)) return NULL;
 
     PropVariantInit(&id);
     PropVariantInit(&value);




More information about the wine-cvs mailing list