Michael Stefaniuc : winhlp32: Simplify code that happened to work by chance (PVS-Studio).

Alexandre Julliard julliard at wine.codeweavers.com
Fri Mar 6 06:27:28 CST 2015


Module: wine
Branch: master
Commit: 9bf064a67a9e884d2b6766a065a0a3e50a542ccf
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=9bf064a67a9e884d2b6766a065a0a3e50a542ccf

Author: Michael Stefaniuc <mstefani at redhat.de>
Date:   Fri Mar  6 10:17:21 2015 +0100

winhlp32: Simplify code that happened to work by chance (PVS-Studio).

---

 programs/winhlp32/winhelp.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/programs/winhlp32/winhelp.c b/programs/winhlp32/winhelp.c
index ee5eecd..17fe90c 100644
--- a/programs/winhlp32/winhelp.c
+++ b/programs/winhlp32/winhelp.c
@@ -1519,11 +1519,11 @@ static LRESULT CALLBACK WINHELP_MainWndProc(HWND hWnd, UINT msg, WPARAM wParam,
     case WM_INITMENUPOPUP:
         win = (WINHELP_WINDOW*) GetWindowLongPtrW(hWnd, 0);
         CheckMenuItem((HMENU)wParam, MNID_OPTS_FONTS_SMALL,
-                      MF_BYCOMMAND | (win->font_scale == 0) ? MF_CHECKED : 0);
+                      (win->font_scale == 0) ? MF_CHECKED : MF_UNCHECKED);
         CheckMenuItem((HMENU)wParam, MNID_OPTS_FONTS_NORMAL,
-                      MF_BYCOMMAND | (win->font_scale == 1) ? MF_CHECKED : 0);
+                      (win->font_scale == 1) ? MF_CHECKED : MF_UNCHECKED);
         CheckMenuItem((HMENU)wParam, MNID_OPTS_FONTS_LARGE,
-                      MF_BYCOMMAND | (win->font_scale == 2) ? MF_CHECKED : 0);
+                      (win->font_scale == 2) ? MF_CHECKED : MF_UNCHECKED);
         break;
     case WM_DESTROY:
         win = (WINHELP_WINDOW*) GetWindowLongPtrW(hWnd, 0);




More information about the wine-cvs mailing list