Michael Stefaniuc : dsound: Avoid comparing BOOL variables with TRUE ( PVS-Studio).

Alexandre Julliard julliard at wine.codeweavers.com
Mon Mar 9 08:43:17 CDT 2015


Module: wine
Branch: master
Commit: 91e59d99f93907b464ae3d8d16547868476557af
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=91e59d99f93907b464ae3d8d16547868476557af

Author: Michael Stefaniuc <mstefani at redhat.de>
Date:   Mon Mar  9 10:27:08 2015 +0100

dsound: Avoid comparing BOOL variables with TRUE (PVS-Studio).

---

 dlls/dsound/dsound_main.c | 2 +-
 dlls/dsound/mixer.c       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/dsound/dsound_main.c b/dlls/dsound/dsound_main.c
index 0e3a313..0130607 100644
--- a/dlls/dsound/dsound_main.c
+++ b/dlls/dsound/dsound_main.c
@@ -528,7 +528,7 @@ HRESULT enumerate_mmdevices(EDataFlow flow, GUID *guids,
 
     release_mmdevenum(devenum, init_hr);
 
-    return (keep_going == TRUE) ? S_OK : S_FALSE;
+    return keep_going ? S_OK : S_FALSE;
 }
 
 /***************************************************************************
diff --git a/dlls/dsound/mixer.c b/dlls/dsound/mixer.c
index b367086..973a65e 100644
--- a/dlls/dsound/mixer.c
+++ b/dlls/dsound/mixer.c
@@ -841,7 +841,7 @@ static void DSOUND_PerformMix(DirectSoundDevice *device)
 		}
 
 		/* if device was stopping, its for sure stopped when all buffers have stopped */
-		else if((all_stopped == TRUE) && (device->state == STATE_STOPPING)){
+		else if (all_stopped && (device->state == STATE_STOPPING)) {
 			TRACE("All buffers have stopped. Stopping primary buffer\n");
 			device->state = STATE_STOPPED;
 




More information about the wine-cvs mailing list