Michael Stefaniuc : msi: Remove comparison of pointer with >= NULL ( PVS-Studio).

Alexandre Julliard julliard at wine.codeweavers.com
Mon Mar 9 08:43:18 CDT 2015


Module: wine
Branch: master
Commit: be813aed6f61af30a45ca85014a417b39ea66cd1
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=be813aed6f61af30a45ca85014a417b39ea66cd1

Author: Michael Stefaniuc <mstefani at redhat.de>
Date:   Mon Mar  9 10:30:56 2015 +0100

msi: Remove comparison of pointer with >= NULL (PVS-Studio).

---

 dlls/msi/database.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/dlls/msi/database.c b/dlls/msi/database.c
index 940d3d9..dd2c004 100644
--- a/dlls/msi/database.c
+++ b/dlls/msi/database.c
@@ -155,8 +155,7 @@ UINT MSI_OpenDatabaseW(LPCWSTR szDBPath, LPCWSTR szPersist, MSIDATABASE **pdb)
     if( !pdb )
         return ERROR_INVALID_PARAMETER;
 
-    if (szPersist - MSIDBOPEN_PATCHFILE >= MSIDBOPEN_READONLY &&
-        szPersist - MSIDBOPEN_PATCHFILE <= MSIDBOPEN_CREATEDIRECT)
+    if (szPersist - MSIDBOPEN_PATCHFILE <= MSIDBOPEN_CREATEDIRECT)
     {
         TRACE("Database is a patch\n");
         szPersist -= MSIDBOPEN_PATCHFILE;




More information about the wine-cvs mailing list