Michael Stefaniuc : ws2_32: Avoid using bitwise operations on BOOLs ( PVS-Studio).

Alexandre Julliard julliard at wine.codeweavers.com
Tue Mar 10 10:10:03 CDT 2015


Module: wine
Branch: master
Commit: 58afc397cb27dc9e8790c53cc7e9d5d4bdd6672e
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=58afc397cb27dc9e8790c53cc7e9d5d4bdd6672e

Author: Michael Stefaniuc <mstefani at redhat.de>
Date:   Tue Mar 10 10:20:02 2015 +0100

ws2_32: Avoid using bitwise operations on BOOLs (PVS-Studio).

---

 dlls/ws2_32/socket.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c
index b4ed865..a9f60cc 100644
--- a/dlls/ws2_32/socket.c
+++ b/dlls/ws2_32/socket.c
@@ -3938,7 +3938,7 @@ INT WINAPI WSAIoctl(SOCKET s, DWORD code, LPVOID in_buff, DWORD in_size, LPVOID
              * because BSD returns TRUE if it's in the OOB mark
              * while Windows returns TRUE if there are NO OOB bytes.
              */
-            (*(WS_u_long *) out_buff) = oob | !atmark;
+            (*(WS_u_long *) out_buff) = oob || !atmark;
         }
 
         release_sock_fd( s, fd );




More information about the wine-cvs mailing list