Sebastian Lackner : ole32: Fix call to free_stringtable with uninitialized pointer (Coverity).

Alexandre Julliard julliard at wine.codeweavers.com
Wed Mar 11 10:00:42 CDT 2015


Module: wine
Branch: master
Commit: 59a1bcd96ac3ca84290cb4449021d24b6f7abdcd
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=59a1bcd96ac3ca84290cb4449021d24b6f7abdcd

Author: Sebastian Lackner <sebastian at fds-team.de>
Date:   Wed Mar 11 01:19:22 2015 +0100

ole32: Fix call to free_stringtable with uninitialized pointer (Coverity).

---

 dlls/ole32/filemoniker.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/dlls/ole32/filemoniker.c b/dlls/ole32/filemoniker.c
index c7bbb66..732d6ac 100644
--- a/dlls/ole32/filemoniker.c
+++ b/dlls/ole32/filemoniker.c
@@ -924,7 +924,8 @@ static HRESULT WINAPI
 FileMonikerImpl_CommonPrefixWith(IMoniker* iface,IMoniker* pmkOther,IMoniker** ppmkPrefix)
 {
 
-    LPOLESTR pathThis = NULL, pathOther = NULL,*stringTable1,*stringTable2,commonPath = NULL;
+    LPOLESTR pathThis = NULL, pathOther = NULL, *stringTable1 = NULL;
+    LPOLESTR *stringTable2 = NULL, commonPath = NULL;
     IBindCtx *bindctx;
     DWORD mkSys;
     ULONG nb1,nb2,i,sameIdx;
@@ -1012,8 +1013,8 @@ failed:
     CoTaskMemFree(pathThis);
     CoTaskMemFree(pathOther);
     CoTaskMemFree(commonPath);
-    free_stringtable(stringTable1);
-    free_stringtable(stringTable2);
+    if (stringTable1) free_stringtable(stringTable1);
+    if (stringTable2) free_stringtable(stringTable2);
 
     return ret;
 }




More information about the wine-cvs mailing list